Skip to content

fix(discovery): do not sync shares with "Allow download and sync" unset#9963

Open
nilsding wants to merge 4 commits into
masterfrom
bugfix/noid/no-download-and-sync-folders
Open

fix(discovery): do not sync shares with "Allow download and sync" unset#9963
nilsding wants to merge 4 commits into
masterfrom
bugfix/noid/no-download-and-sync-folders

Conversation

@nilsding
Copy link
Copy Markdown
Member

@nilsding nilsding commented May 4, 2026

The option does not only apply to files, but also to folders.

Also: do not display shared items without that option in Windows on-demand folders

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@nilsding
Copy link
Copy Markdown
Member Author

nilsding commented May 4, 2026

/backport to stable-33.0

@nilsding nilsding force-pushed the bugfix/noid/no-download-and-sync-folders branch from cde4c08 to a7f0efb Compare May 13, 2026 12:43
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
98 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@nilsding nilsding force-pushed the bugfix/noid/no-download-and-sync-folders branch from a7f0efb to cc096f3 Compare May 18, 2026 07:43
nilsding added 4 commits May 18, 2026 11:40
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
… permission

The permission does not only apply to files, but also to folders.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
otherwise cfapi would list folders that are skipped by the sync
engine itself

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding nilsding force-pushed the bugfix/noid/no-download-and-sync-folders branch from cc096f3 to bc3c581 Compare May 18, 2026 09:46
@github-actions
Copy link
Copy Markdown

Artifact containing the AppImage: nextcloud-appimage-pr-9963.zip

Digest: sha256:95f438409d5f9705e8edabf4cca47f673a793afe630ad6e5ec5eed08d5874403

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant